wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()
authorWei Chen <harperchen1110@gmail.com>
Sun, 26 Mar 2023 05:42:17 +0000 (05:42 +0000)
committerKalle Valo <kvalo@kernel.org>
Fri, 31 Mar 2023 14:51:33 +0000 (17:51 +0300)
commit5dbe1f8eb8c5ac69394400a5b86fd81775e96c43
treee323569940efb833944d32706a3b5faf59de3b1e
parent905a9241e4e8c15d2c084fee916280514848fe35
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326054217.93492-1-harperchen1110@gmail.com
drivers/net/wireless/realtek/rtlwifi/debug.c