rtsp+rtmp: Forward warning added to tls-validation-flags to our users
authorNirbheek Chauhan <nirbheek@centricular.com>
Wed, 25 May 2022 13:10:30 +0000 (18:40 +0530)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Sat, 30 Jul 2022 11:27:12 +0000 (11:27 +0000)
commit5da9f6231337b75da34baac8c70f2c511958c2b8
treefa85f0836aa7262ba457fd732580be89cffaddfc
parent11ecda9d73c5cd80f0b1ae3dd8a276af2c6e8dc1
rtsp+rtmp: Forward warning added to tls-validation-flags to our users

With the 2.72 release, glib-networking developers have decided that
TLS certificate validation cannot be implemented correctly by them, so
they've deprecated it.

In a nutshell: a cert can have several validation errors, but there
are no guarantees that the TLS backend will return all those errors,
and things are made even more complicated by the fact that the list of
errors might refer to certs that are added for backwards-compat and
won't actually be used by the TLS library.

Our best option is to ignore the deprecation and pass the warning onto
users so they can make an appropriate security decision regarding
this.

We can't deprecate the tls-validation-flags property because it is
very useful when connecting to RTSP cameras that will never get
updates to fix certificate errors.

Relevant upstream merge requests / issues:

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2214

https://gitlab.gnome.org/GNOME/glib-networking/-/issues/179

https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/193

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2494>
subprojects/gst-plugins-bad/gst/rtmp2/gstrtmp2locationhandler.c
subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c
subprojects/gst-plugins-base/gst-libs/gst/rtsp/gstrtspconnection.c
subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c
subprojects/gst-rtsp-server/gst/rtsp-sink/gstrtspclientsink.c