sunrpc: correct the computation for page_ptr when truncating
authorFrank Sorenson <sorenson@redhat.com>
Tue, 30 Oct 2018 20:10:40 +0000 (15:10 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 5 Nov 2018 16:52:06 +0000 (11:52 -0500)
commit5d7a5bcb67c70cbc904057ef52d3fcfeb24420bb
treea7df55e7dba5e2d8da10dcc7c1de8e061e1e461c
parent651022382c7f8da46cb4872a545ee1da6d097d2a
sunrpc: correct the computation for page_ptr when truncating

When truncating the encode buffer, the page_ptr is getting
advanced, causing the next page to be skipped while encoding.
The page is still included in the response, so the response
contains a page of bogus data.

We need to adjust the page_ptr backwards to ensure we encode
the next page into the correct place.

We saw this triggered when concurrent directory modifications caused
nfsd4_encode_direct_fattr() to return nfserr_noent, and the resulting
call to xdr_truncate_encode() corrupted the READDIR reply.

Signed-off-by: Frank Sorenson <sorenson@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/xdr.c