Parsing: Make Scope not know about Isolate.
authormarja <marja@chromium.org>
Tue, 10 Feb 2015 14:39:00 +0000 (06:39 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 10 Feb 2015 14:39:21 +0000 (14:39 +0000)
commit5d68529be240a1fc9fcc67c8950ead4baf7604e4
tree694ef8b0e473e742aa570cf220a39374aa29eb4b
parent86cae1633caa31f2225b6932850fb13d3a21cf59
Parsing: Make Scope not know about Isolate.

Scope, like Parser, must be able to operate independent of Isolate and the V8
heap (for background parsing). After the heap-independent phase, there is a heap
dependent phase, during which we do operations such as scope anaylysis.

This CL makes the phases explicit by not telling Scope about the Isolate too
early (during the heap-independent phase, Scope should know nothing about
Isolate). This decreases the probability of accidental code changes which would
add heap-dependent operations into the heap-independent phase.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/909093003

Cr-Commit-Position: refs/heads/master@{#26546}
12 files changed:
src/arm/full-codegen-arm.cc
src/arm64/full-codegen-arm64.cc
src/compiler/ast-graph-builder.cc
src/full-codegen.cc
src/hydrogen.cc
src/ia32/full-codegen-ia32.cc
src/preparser.h
src/runtime/runtime-debug.cc
src/scopes.cc
src/scopes.h
src/x64/full-codegen-x64.cc
test/cctest/test-parsing.cc