efi_loader: capsule: Record capsule result only if capsule is read
authorMasami Hiramatsu <masami.hiramatsu@linaro.org>
Fri, 12 Nov 2021 13:05:15 +0000 (22:05 +0900)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 20 Nov 2021 09:53:00 +0000 (10:53 +0100)
commit5d49b32f0a34cc4c23da8060ac18345984c9b96c
tree858bc5fb0047e2042ced2e4ec9faa40542e4d246
parent3961bd9b552bfb3c08664fb09f18744c6f691456
efi_loader: capsule: Record capsule result only if capsule is read

Record capsule update result only if the capsule file is
successfully read, because the capsule GUID is not sure when
the file can not be read or the file is not a capsule.
Without this fix, if user puts a dummy (non-capsule) file
under (ESP)EFI/UpdateCapsule, U-Boot causes a synchronous
abort.

This also fixes use-after-free bug of the 'capsule' variable.

Fixes: c74cd8bd08d1 ("efi_loader: capsule: add capsule_on_disk support")
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
lib/efi_loader/efi_capsule.c