xenbus: req->err should be updated before req->state
authorDongli Zhang <dongli.zhang@oracle.com>
Tue, 3 Mar 2020 22:14:23 +0000 (14:14 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2020 07:25:49 +0000 (08:25 +0100)
commit5d33ba6f385f3cb9790b707df6ea93839e7d2cf9
tree2025fa4f82fb325446b154686c8fffb6098c8e4e
parent7a79e217e3a59afd95bd8a92e4ab9b92ee73868d
xenbus: req->err should be updated before req->state

[ Upstream commit 8130b9d5b5abf26f9927b487c15319a187775f34 ]

This patch adds the barrier to guarantee that req->err is always updated
before req->state.

Otherwise, read_reply() would not return ERR_PTR(req->err) but
req->body, when process_writes()->xb_write() is failed.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20200303221423.21962-2-dongli.zhang@oracle.com
Reviewed-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/xen/xenbus/xenbus_comms.c