net: generalize calculation of skb extensions length
authorThomas Weißschuh <linux@weissschuh.net>
Wed, 23 Aug 2023 09:28:38 +0000 (11:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 24 Aug 2023 18:24:30 +0000 (11:24 -0700)
commit5d21d0a65b573507bae774708199328b38dedfe6
tree68a78d5da1852eac198cb8092876082256893497
parent57ce6427e00a6a72f74b29630b39548b36980b09
net: generalize calculation of skb extensions length

Remove the necessity to modify skb_ext_total_length() when new extension
types are added.
Also reduces the line count a bit.

With optimizations enabled the function is folded down to the same
constant value as before during compilation.
This has been validated on x86 with GCC 6.5.0 and 13.2.1.
Also a similar construct has been validated on godbolt.org with GCC 5.1.
In any case the compiler has to be able to evaluate the construct at
compile-time for the BUILD_BUG_ON() in skb_extensions_init().

Even if not evaluated at compile-time this function would only ever
be executed once at run-time, so the overhead would be very minuscule.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230823-skb_ext-simplify-v2-1-66e26cd66860@weissschuh.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c