Revert "staging: comedi: cb_pcidas64: change params to external_ai_queue_in_use()"
authorIan Abbott <abbotti@mev.co.uk>
Fri, 23 Mar 2018 13:54:32 +0000 (13:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Mar 2018 14:55:21 +0000 (15:55 +0100)
commit5d20e467dfadf14b9437d2b04040a3a342974ec9
tree5c9b09cb37dbe496fa9f4ae755551c6f04af8be3
parent1e8ac83b6caf9567a8d68b3e650b7a093fd47e4b
Revert "staging: comedi: cb_pcidas64: change params to external_ai_queue_in_use()"

This reverts commit f5f3a2c6569e ("staging: comedi: cb_pcidas64: change
params to external_ai_queue_in_use()").  The
`external_ai_queue_in_use()` was being called from `ao_cmd()` with
pointers to the "write" subdevice and AO command, but is supposed to
check whether the external AI queue is currently in use by the "read"
subdevice and AI command.  In fact, the return value always indicated
that the external AI queue was not in use in this case (because the AO
command's channel list is sequential), so was fairly useless.  (However,
even before the reverted commit, the logic in
`external_ai_queue_in_use()` was wrong.  That will be corrected in a
subsequent commit.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/cb_pcidas64.c