i965/fs: Properly patch special values during VGRF compaction.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 15 Nov 2012 04:50:05 +0000 (20:50 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Sat, 17 Nov 2012 22:37:16 +0000 (14:37 -0800)
commit5cea0273414bd5897c318b4d632b08ce8080a2fe
tree35cfbb723d3310c8f1dba45c0284dc89c630c67f
parent3c368bb307544a51f8b8d13f0d496a742086c9e2
i965/fs: Properly patch special values during VGRF compaction.

In addition to registers used by instructions, fs_visitor maintains
direct references to certain "special" values used for inputs/outputs.

When I added VGRF compaction, I overlooked these, believing that these
direct references weren't used once instructions were generated.  That
was wrong.  For example, pixel_x/y are used in virtual_grf_interferes(),
which is called by optimization passes and register allocation.

This patch treats all of them as used and patches them after compacting.
While it's not strictly necessary to patch all of them (as some aren't
used after emitting code), it seems safer to simply fix them all.

Fixes oglconform's textureswizzle/advanced.shader.targets, piglit's
glsl-fs-lots-of-tex, and glean's texCombine on pre-Gen6 hardware.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56790
Reviewed-by: Eric Anholt <eric@anholt.net>
src/mesa/drivers/dri/i965/brw_fs.cpp