c++: ICE with -Wlogical-op [PR107755]
authorMarek Polacek <polacek@redhat.com>
Tue, 31 Jan 2023 19:36:30 +0000 (14:36 -0500)
committerMarek Polacek <polacek@redhat.com>
Wed, 1 Feb 2023 13:30:55 +0000 (08:30 -0500)
commit5ce8961b46f050a96e8c542b34b1cf024ba95f1b
treed445ecf6bce4cdfd1958307a67dee6a739d8be8c
parent1d77bfdf11fb9d7f9fcce7ed8817fc2877b3ded2
c++: ICE with -Wlogical-op [PR107755]

Here we crash in the middle end because warn_logical_operator calls
build_range_check which calls various fold_* functions and those
don't work too well when we're still processing template trees.  For
instance here we crash because we're converting a RECORD_TYPE to bool.
At this point VIEW_CONVERT_EXPR<struct Foo>(b) hasn't yet been converted
to Foo::operator bool (&b).

I was excited to fix this with instantiation_dependent_expression_p
which can now be called from c-family/ as well, but the problem isn't
that the expression is dependent.  So, p_t_d it is.

PR c++/107755

gcc/cp/ChangeLog:

* call.cc (build_new_op): Don't call warn_logical_operator when
processing a template.

gcc/testsuite/ChangeLog:

* g++.dg/warn/Wlogical-op-4.C: New test.
gcc/cp/call.cc
gcc/testsuite/g++.dg/warn/Wlogical-op-4.C [new file with mode: 0644]