nptl: Add one more barrier to nptl/tst-create1
authorFlorian Weimer <fweimer@redhat.com>
Fri, 10 Dec 2021 04:14:24 +0000 (05:14 +0100)
committerFlorian Weimer <fweimer@redhat.com>
Fri, 10 Dec 2021 10:51:25 +0000 (11:51 +0100)
commit5cc338565479a620244c2f8ff35956629c4dbf81
tree4d34939dc95aebbf4b5c57012d0e091394bb6c4f
parent627f5ede70d70c77bdaf857db07404e8bf7f60af
nptl: Add one more barrier to nptl/tst-create1

Without the bar_ctor_finish barrier, it was possible that thread2
re-locked user_lock before ctor had a chance to lock it.  ctor then
blocked in its locking operation, xdlopen from the main thread
did not return, and thread2 was stuck waiting in bar_dtor:

thread 1: started.
thread 2: started.
thread 2: locked user_lock.
constructor started: 0.
thread 1: in ctor: started.
thread 3: started.
thread 3: done.
thread 2: unlocked user_lock.
thread 2: locked user_lock.

Fixes the test in commit 83b5323261bb72313bffcf37476c1b8f0847c736
("elf: Avoid deadlock between pthread_create and ctors [BZ #28357]").

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
sysdeps/pthread/tst-create1.c