dump_stack: avoid the livelock of the dump_lock
authorKevin Hao <haokexin@gmail.com>
Wed, 6 Nov 2019 05:16:57 +0000 (21:16 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 6 Nov 2019 16:47:50 +0000 (08:47 -0800)
commit5cbf2fff3bba8d3c6a4d47c1754de1cf57e2b01f
tree25bc30bf2caa8885f914a052558a8b2b62257ab4
parenta31631302abce4c80913d4dc741c4a6b07969b0e
dump_stack: avoid the livelock of the dump_lock

In the current code, we use the atomic_cmpxchg() to serialize the output
of the dump_stack(), but this implementation suffers the thundering herd
problem.  We have observed such kind of livelock on a Marvell cn96xx
board(24 cpus) when heavily using the dump_stack() in a kprobe handler.
Actually we can let the competitors to wait for the releasing of the
lock before jumping to atomic_cmpxchg().  This will definitely mitigate
the thundering herd problem.  Thanks Linus for the suggestion.

[akpm@linux-foundation.org: fix comment]
Link: http://lkml.kernel.org/r/20191030031637.6025-1-haokexin@gmail.com
Fixes: b58d977432c8 ("dump_stack: serialize the output from dump_stack()")
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/dump_stack.c