mac80211: radiotap: Use BIT() instead of shifts
authorKees Cook <keescook@chromium.org>
Fri, 6 Aug 2021 21:51:12 +0000 (14:51 -0700)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 13 Aug 2021 07:58:25 +0000 (09:58 +0200)
commit5cafd3784a738eab8bbfcda17e8571050794ef32
tree061d4c6909a0519e6680a6809ed7c20e09248391
parent0323689d30af3523f26ac05b69537fd90d7b94da
mac80211: radiotap: Use BIT() instead of shifts

IEEE80211_RADIOTAP_EXT has a value of 31, which means if shift was ever
cast to 64-bit, the result would become sign-extended. As a matter of
robustness, just replace all the open-coded shifts with BIT().

Suggested-by: David Sterba <dsterba@suse.cz>
Link: https://lore.kernel.org/lkml/20210728092323.GW5047@twin.jikos.cz/
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210806215112.2874773-1-keescook@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c
net/mac80211/status.c
net/wireless/radiotap.c