x86/pvclock: Improve atomic update of last_value in pvclock_clocksource_read()
authorUros Bizjak <ubizjak@gmail.com>
Thu, 26 Jan 2023 15:08:35 +0000 (16:08 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 31 Jan 2023 14:01:46 +0000 (15:01 +0100)
commit5c9da9fe826d4a0d84bb322cca27cc8ad8d23b24
tree40d9cd963fc5af7264ff8d6386304b350c8ddfbe
parent7aab7aa4b4bed2b9030fcdd207e0f3a5d257bda0
x86/pvclock: Improve atomic update of last_value in pvclock_clocksource_read()

Improve atomic update of last_value in pvclock_clocksource_read:

- Atomic update can be skipped if the "last_value" is already
  equal to "ret".

- The detection of atomic update failure is not correct. The value,
  returned by atomic64_cmpxchg should be compared to the old value
  from the location to be updated. If these two are the same, then
  atomic update succeeded and "last_value" location is updated to
  "ret" in an atomic way. Otherwise, the atomic update failed and
  it should be retried with the value from "last_value" - exactly
  what atomic64_try_cmpxchg does in a correct and more optimal way.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20230118202330.3740-1-ubizjak@gmail.com
Link: https://lore.kernel.org/r/20230126151323.643408110@infradead.org
arch/x86/kernel/pvclock.c