video: fbdev: cirrusfb: check pixclock to avoid divide by zero
authorGeorge Kennedy <george.kennedy@oracle.com>
Wed, 27 Oct 2021 20:30:13 +0000 (15:30 -0500)
committerHelge Deller <deller@gmx.de>
Sat, 29 Jan 2022 22:32:49 +0000 (23:32 +0100)
commit5c6f402bdcf9e7239c6bc7087eda71ac99b31379
treec5a68e60aeef00b0b0711564fd150822b776b321
parent81b63420564da2e4912733a966e87d6022ff313a
video: fbdev: cirrusfb: check pixclock to avoid divide by zero

Do a sanity check on pixclock value to avoid divide by zero.

If the pixclock value is zero, the cirrusfb driver will round up
pixclock to get the derived frequency as close to maxclock as
possible.

Syzkaller reported a divide error in cirrusfb_check_pixclock.

divide error: 0000 [#1] SMP KASAN PTI
CPU: 0 PID: 14938 Comm: cirrusfb_test Not tainted 5.15.0-rc6 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2
RIP: 0010:cirrusfb_check_var+0x6f1/0x1260

Call Trace:
 fb_set_var+0x398/0xf90
 do_fb_ioctl+0x4b8/0x6f0
 fb_ioctl+0xeb/0x130
 __x64_sys_ioctl+0x19d/0x220
 do_syscall_64+0x3a/0x80
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Signed-off-by: George Kennedy <george.kennedy@oracle.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/cirrusfb.c