maple_tree: add mas_is_active() to detect in-tree walks
authorLiam R. Howlett <Liam.Howlett@oracle.com>
Thu, 21 Sep 2023 18:12:35 +0000 (14:12 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 30 Sep 2023 00:20:46 +0000 (17:20 -0700)
commit5c590804b6b0ff933ed4e5cee5d76de3a5048d9f
treeeaba1036909d61a02ee8660c003f2271b154d75c
parent7ee29facd8a9c5a26079148e36bcf07141b3a6bc
maple_tree: add mas_is_active() to detect in-tree walks

Patch series "maple_tree: Fix mas_prev() state regression".

Pedro Falcato retported an mprotect regression [1] which was bisected back
to the iterator changes for maple tree.  Root cause analysis showed the
mas_prev() running off the end of the VMA space (previous from 0) followed
by mas_find(), would skip the first value.

This patchset introduces maple state underflow/overflow so the sequence of
calls on the maple state will return what the user expects.

Users who encounter this bug may see mprotect(), userfaultfd_register(),
and mlock() fail on VMAs mapped with address 0.

This patch (of 2):

Instead of constantly checking each possibility of the maple state,
create a fast path that will skip over checking unlikely states.

Link: https://lkml.kernel.org/r/20230921181236.509072-1-Liam.Howlett@oracle.com
Link: https://lkml.kernel.org/r/20230921181236.509072-2-Liam.Howlett@oracle.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/maple_tree.h