rfs: annotate lockless accesses to RFS sock flow table
authorEric Dumazet <edumazet@google.com>
Tue, 6 Jun 2023 07:41:15 +0000 (07:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Jun 2023 09:08:45 +0000 (10:08 +0100)
commit5c3b74a92aa285a3df722bf6329ba7ccf70346d6
treea5898632fd2ce3dd1f7dfca691a0a1f6dfdf1231
parent1e5c647c3f6d4f8497dedcd226204e1880e0ffb3
rfs: annotate lockless accesses to RFS sock flow table

Add READ_ONCE()/WRITE_ONCE() on accesses to the sock flow table.

This also prevents a (smart ?) compiler to remove the condition in:

if (table->ents[index] != newval)
        table->ents[index] = newval;

We need the condition to avoid dirtying a shared cache line.

Fixes: fec5e652e58f ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h
net/core/dev.c