[mlir] Drop the leading space when printing regions
authorMogball <jeffniu22@gmail.com>
Tue, 18 Jan 2022 07:47:25 +0000 (07:47 +0000)
committerMogball <jeffniu22@gmail.com>
Tue, 18 Jan 2022 16:52:34 +0000 (16:52 +0000)
commit5c36ee8d57fa702d8dc4ee9349978bff575a9465
tree375916c71f8d590c693149ca5498bb8385077c82
parent53a51acc361a6b20b23b032226b0a7b124465cf7
[mlir] Drop the leading space when printing regions

The leading space that is always printed at the beginning of regions is not consistent with other parts of the printing API. Moreover, this leading space can lead to undesirable assembly formats:

```
attr-dict-with-keyword $region
```

Prints as:

```
// Two spaces between `}` and `{`
attributes {foo}  { ... }
```

Moreover, the leading space results in the odd generic op format:

```
"test.op"() ( {...}) : () -> ()
```

Reviewed By: rriddle, mehdi_amini

Differential Revision: https://reviews.llvm.org/D117411
40 files changed:
flang/lib/Optimizer/Dialect/FIROps.cpp
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
mlir/lib/Dialect/Async/IR/Async.cpp
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
mlir/lib/Dialect/PDLInterp/IR/PDLInterp.cpp
mlir/lib/Dialect/SCF/SCF.cpp
mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
mlir/lib/Dialect/Shape/IR/Shape.cpp
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
mlir/lib/IR/AsmPrinter.cpp
mlir/lib/IR/FunctionImplementation.cpp
mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
mlir/test/Conversion/TosaToSCF/tosa-to-scf.mlir
mlir/test/Dialect/Affine/ops.mlir
mlir/test/Dialect/Bufferization/Transforms/buffer-deallocation.mlir
mlir/test/Dialect/GPU/invalid.mlir
mlir/test/Dialect/GPU/ops.mlir
mlir/test/Dialect/Linalg/invalid.mlir
mlir/test/Dialect/Linalg/named-ops.mlir
mlir/test/Dialect/MemRef/invalid.mlir
mlir/test/Dialect/Tosa/inlining.mlir
mlir/test/Dialect/Tosa/ops.mlir
mlir/test/Dialect/Tosa/tosa-infer-shapes.mlir
mlir/test/IR/invalid-ops.mlir
mlir/test/IR/parser.mlir
mlir/test/IR/pretty-region-args.mlir
mlir/test/IR/pretty_printed_region_op.mlir
mlir/test/IR/region.mlir
mlir/test/IR/wrapping_op.mlir
mlir/test/Target/LLVMIR/openmp-llvm.mlir
mlir/test/Transforms/test-merge-blocks.mlir
mlir/test/lib/Dialect/Test/TestDialect.cpp
mlir/test/mlir-lsp-server/hover.test
mlir/test/mlir-tblgen/op-format.mlir
mlir/test/python/ir/operation.py