[flang] Address review comments.
authorTim Keith <tkeith@nvidia.com>
Wed, 6 Jun 2018 18:41:42 +0000 (11:41 -0700)
committerTim Keith <tkeith@nvidia.com>
Wed, 6 Jun 2018 18:41:42 +0000 (11:41 -0700)
commit5c27c9ea3f884376c5451df699c0cc5e6bbd613f
tree61c6b0b53823f026f1a50654785bfd73d6a6fe3f
parent348ccb784e4dda00b40fde201b38302441ae853c
[flang] Address review comments.

Replace operator=(Symbol) and operator=(DeclTypeSpec) with set_symbol()
and set_type() to make it clearer. Eliminate the move constructor as it
is not needed. Make all but the accessor functions out-of-line.

Change HasExplicitType() to NeedsExplicitType(), reversing its sense.
HasExplicitType() returned true for symbols that didn't have or need an
explicit type, which was confusing.

Original-commit: flang-compiler/f18@ada13ac6a32145fe260d78cb0e736998e5eabd15
Reviewed-on: https://github.com/flang-compiler/f18/pull/97
flang/lib/semantics/resolve-names.cc
flang/lib/semantics/symbol.cc
flang/lib/semantics/type.cc
flang/lib/semantics/type.h