Remove always defined FEATURE_RANDOMIZE_STRING_HASHING define (#13491)
authorDan Moseley <danmose@microsoft.com>
Mon, 28 Aug 2017 06:51:22 +0000 (23:51 -0700)
committerGitHub <noreply@github.com>
Mon, 28 Aug 2017 06:51:22 +0000 (23:51 -0700)
commit5c07c5aa98f8a088bf25099f1ab2d38b59ea5478
treecca21075b126112fef646b28ff646cf9f5313516
parent0db6d91ec163eb2ddc005d141fe13ee0df267af0
Remove always defined FEATURE_RANDOMIZE_STRING_HASHING define (#13491)

* Remove always defined FEATURE_RANDOMIZE_STRING_HASHING

* Fully remove randomized hashing

* Leftovers

* Remove additionalEntropy from HashSortKey as it was always 0

* Remove additionalEntropy from HashString as it was always 0

* Change to private, as not in fact called by reflection in .NET Core

* Fix build break due to FCDECLn

* Revert removed QCALL

* Remove unused strlen parameter
26 files changed:
clr.coreclr.props
clr.defines.targets
clrdefinitions.cmake
crossgen.cmake
src/classlibnative/bcltype/stringnative.cpp
src/classlibnative/bcltype/stringnative.h
src/classlibnative/inc/nlsinfo.h
src/classlibnative/nls/nlsinfo.cpp
src/inc/MSCOREE.IDL
src/inc/clrconfigvalues.h
src/mscorlib/src/System/AppDomainSetup.cs
src/mscorlib/src/System/Collections/Concurrent/ConcurrentDictionary.cs
src/mscorlib/src/System/Collections/Generic/Dictionary.cs
src/mscorlib/src/System/Collections/Generic/EqualityComparer.cs
src/mscorlib/src/System/Collections/Hashtable.cs
src/mscorlib/src/System/Globalization/CompareInfo.Unix.cs
src/mscorlib/src/System/Globalization/CompareInfo.Windows.cs
src/mscorlib/src/System/String.Comparison.cs
src/pal/prebuilt/inc/mscoree.h
src/vm/appdomain.cpp
src/vm/comutilnative.cpp
src/vm/comutilnative.h
src/vm/crossgen_mscorlib/CMakeLists.txt
src/vm/ecalllist.h
src/vm/mscorlib.h
src/vm/object.h