rtc: isl1208: Fix unintended clear of SR bits
authorDenis Osterland <Denis.Osterland@diehl.com>
Tue, 23 Jan 2018 12:17:58 +0000 (13:17 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 1 Mar 2018 09:49:36 +0000 (10:49 +0100)
commit5b9fc795f90c0c509a24ba1f64d0d960f09e40da
treef59ae79ad744364c0cae16f02b0166e818632f01
parentdd888c61c9d4ef54d5a9884226989e3cceaacbd3
rtc: isl1208: Fix unintended clear of SR bits

After successful
sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
sr will be 0.
As a result
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
sr & ~ISL1208_REG_SR_WRTC);
is equal to
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0);
which clears all flags in SR.

Add an additional read of SR, to have value of SR in sr again.

Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-isl1208.c