Revert "btrfs: turn name_cache radix tree into XArray in send_ctx"
authorDavid Sterba <dsterba@suse.com>
Fri, 15 Jul 2022 11:59:38 +0000 (13:59 +0200)
committerDavid Sterba <dsterba@suse.com>
Fri, 15 Jul 2022 17:14:58 +0000 (19:14 +0200)
commit5b8418b84303d9a0a0f7f28d6eaed915247ebdc3
tree2cb82a8e050cd3de708f79c43e185f4e00d7298d
parent01cd390903e00c8f42ba0e84f25a70e3d613a15c
Revert "btrfs: turn name_cache radix tree into XArray in send_ctx"

This reverts commit 4076942021fe14efecae33bf98566df6dd5ae6f7.

Revert the xarray conversion, there's a problem with potential
sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
allocation. The radix tree used the preloading mechanism to avoid
sleeping but this is not available in xarray.

Conversion from spin lock to mutex is possible but at time of rc6 is
riskier than a clean revert.

[1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/

Reported-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/send.c