KVM: PPC: Book3S HV: Prevent double-free on HPT resize commit path
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 15 Feb 2017 03:40:04 +0000 (14:40 +1100)
committerPaul Mackerras <paulus@ozlabs.org>
Thu, 16 Feb 2017 05:32:19 +0000 (16:32 +1100)
commit5b73d6347eb82cd2a26698fc339607e25e0ad917
tree9895be307c2cdaf2dbe3ac393d5506fe20aa9ac5
parentee10689117c0186fd4fe7feca8d48c7316f65d70
KVM: PPC: Book3S HV: Prevent double-free on HPT resize commit path

resize_hpt_release(), called once the HPT resize of a KVM guest is
completed (successfully or unsuccessfully) frees the state structure for
the resize.  It is currently not safe to call with a NULL pointer.

However, one of the error paths in kvm_vm_ioctl_resize_hpt_commit() can
invoke it with a NULL pointer.  This will occur if userspace improperly
invokes KVM_PPC_RESIZE_HPT_COMMIT without previously calling
KVM_PPC_RESIZE_HPT_PREPARE, or if it calls COMMIT twice without an
intervening PREPARE.

To fix this potential crash bug - and maybe others like it, make it safe
(and a no-op) to call resize_hpt_release() with a NULL resize pointer.

Found by Dan Carpenter with a static checker.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
arch/powerpc/kvm/book3s_64_mmu_hv.c