usb: gadget: goku_udc: Fix mask and set operation on variable master
authorColin Ian King <colin.king@canonical.com>
Fri, 10 Sep 2021 16:31:31 +0000 (17:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Sep 2021 08:27:23 +0000 (10:27 +0200)
commit5b5ec04fb2d646c8c9ec90be2ea638e323912e0f
tree7a9f4e3a4124211207041b51113884667febb9f0
parent6854ccc4688be88e5efd5b1f8300c4289baf0910
usb: gadget: goku_udc: Fix mask and set operation on variable master

The variable master is being masked with ~MST_R_BITS however this
masked value is never used, the following updates to master are
assignments. I suspect the original intention was to mask out the
MST_R_BITS and then bit-wise or in the appropriate read bits rather
than perform an assignment. Fix this by using the |= operator rather
than a straight assignment.

Note that this code is pre-git history, so I can't find a sha for
it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210910163131.94796-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/goku_udc.c