ovl: call posix_acl_release() after error checking
authorChristian Brauner <brauner@kernel.org>
Thu, 3 Nov 2022 07:18:46 +0000 (08:18 +0100)
committerChristian Brauner (Microsoft) <brauner@kernel.org>
Thu, 3 Nov 2022 07:18:46 +0000 (08:18 +0100)
commit5b52aebef8954cadff29918bb61d7fdc7be07837
tree2e2eafedc756efbeccf4eaedbf5afb3f4fe3309c
parent16257cf6658d5bde2a055caf48f143c255abade7
ovl: call posix_acl_release() after error checking

The current placement of posix_acl_release() in ovl_set_or_remove_acl()
means it can be called on an error pointer instead of actual acls.
Fix this by moving the posix_acl_release() call after the error handling.

Fixes: 0e641857322f ("ovl: implement set acl method") # mainline only
Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
fs/overlayfs/inode.c