block: Make bdrv_open() return a BDS
authorMax Reitz <mreitz@redhat.com>
Tue, 17 May 2016 14:41:31 +0000 (16:41 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 25 May 2016 17:04:10 +0000 (19:04 +0200)
commit5b3639371c3e220b41cd2eae8c34c49ad38ef527
tree0f46cc379f81b2ed90b97a36e3fd1b6687e6958a
parent9bddf759790cf1b9c46889f8f8370c90e6ca7610
block: Make bdrv_open() return a BDS

There are no callers to bdrv_open() or bdrv_open_inherit() left that
pass a pointer to a non-NULL BDS pointer as the first argument of these
functions, so we can finally drop that parameter and just make them
return the new BDS.

Generally, the following pattern is applied:

    bs = NULL;
    ret = bdrv_open(&bs, ..., &local_err);
    if (ret < 0) {
        error_propagate(errp, local_err);
        ...
    }

by

    bs = bdrv_open(..., errp);
    if (!bs) {
        ret = -EINVAL;
        ...
    }

Of course, there are only a few instances where the pattern is really
pure.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/block-backend.c
block/vvfat.c
blockdev.c
include/block/block.h