[clang-tidy] In TransformerClangTidyCheck, require Explanation field.
authorYitzhak Mandelbaum <yitzhakm@google.com>
Fri, 24 May 2019 16:32:03 +0000 (16:32 +0000)
committerYitzhak Mandelbaum <yitzhakm@google.com>
Fri, 24 May 2019 16:32:03 +0000 (16:32 +0000)
commit5b33554319cb3aeb88c43ecc6acbbef06a779190
treed1f7ce96d7ad0103d79c2c8d457b8fdf35cfd30d
parent07745a131fa99931e83077e19cfaa4ae46e6c2bc
[clang-tidy] In TransformerClangTidyCheck, require Explanation field.

Summary:
In general, the `Explanation` field is optional in `RewriteRule` cases. But,
because the primary purpose of clang-tidy checks is to provide users with
diagnostics, we assume that a missing explanation is a bug.  This change adds an
assertion that checks all cases for an explanation, and updates the code to rely
on that assertion correspondingly.

Reviewers: ilya-biryukov

Subscribers: xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D62340

llvm-svn: 361647
clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp
clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.h
clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp