mmc: sdhci-brcmstb: Fix mmc timeout errors on S5 suspend
authorAl Cooper <alcooperx@gmail.com>
Thu, 7 Jan 2021 22:15:09 +0000 (17:15 -0500)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 13 Jan 2021 11:06:37 +0000 (12:06 +0100)
commit5b191dcba719319148eeecf6ed409949fac55b39
treea2f341cad096e665b5cfba8dd27fd5104c66f189
parent1a3ed0dc3594d99ff341ec63865a40519ea24b8d
mmc: sdhci-brcmstb: Fix mmc timeout errors on S5 suspend

Commit e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback")
that added a shutdown callback to the diver, is causing "mmc timeout"
errors on S5 suspend. The problem was that the "remove" was queuing
additional MMC commands after the "shutdown" and these caused
timeouts as the MMC queues were cleaned up for "remove". The
shutdown callback will be changed to calling sdhci-pltfm_suspend
which should get better power savings because the clocks will be
shutdown.

Fixes: e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback")
Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210107221509.6597-1-alcooperx@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-brcmstb.c