9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie
authorBharath Vedartham <linux.bhar@gmail.com>
Wed, 22 May 2019 19:45:19 +0000 (01:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:57:29 +0000 (18:57 +0200)
commit5b0446c8e0a85b97148c070f73e273bc3903af5c
treeacc483521a7fc6d9114e515ef5efbd84a94c4dd4
parentd85bc11a6894170292773b9d2f9ec56511d35dc4
9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie

commit 962a991c5de18452d6c429d99f3039387cf5cbb0 upstream.

v9fs_cache_session_get_cookie assigns a random cachetag to v9ses->cachetag,
if the cachetag is not assigned previously.

v9fs_random_cachetag allocates memory to v9ses->cachetag with kmalloc and uses
scnprintf to fill it up with a cachetag.

But if scnprintf fails, v9ses->cachetag is not freed in the current
code causing a memory leak.

Fix this by freeing v9ses->cachetag it v9fs_random_cachetag fails.

This was reported by syzbot, the link to the report is below:
https://syzkaller.appspot.com/bug?id=f012bdf297a7a4c860c38a88b44fbee43fd9bbf3

Link: http://lkml.kernel.org/r/20190522194519.GA5313@bharath12345-Inspiron-5559
Reported-by: syzbot+3a030a73b6c1e9833815@syzkaller.appspotmail.com
Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/9p/cache.c