Remove default constructor lines that do nothing, and fix warnings with clang trunk...
authorBrennan Vincent <btv@fb.com>
Fri, 30 Nov 2018 19:11:51 +0000 (11:11 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 30 Nov 2018 19:16:35 +0000 (11:16 -0800)
commit5ae0ed855286dbbbb50bbcef13bd89f4c2ebadcd
tree189f70d62dd8f19648e4f47d47e6babdb1792825
parentc03851e93a6097211d14f0b3c6d40801c430dbcf
Remove default constructor lines that do nothing, and fix warnings with clang trunk (#14300)

Summary:
The lines removed in this diff were no-op, but confusing: the default constructors in `store_handler.h` are implicitly deleted, since `std::runtime_error` has no default constructor.

Clang added a warning for this behavior [in September 2018](https://reviews.llvm.org/rL343285) (note that the warning is not just for cxx2a, despite the slightly confusing commit message), so building pytorch with a recent build of clang trunk causes spew of this warning, which is fixed by the present PR.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/14300

Differential Revision: D13260039

Pulled By: umanwizard

fbshipit-source-id: 92788dbd6794253e788ef26bde250a66d8fb917e
caffe2/distributed/store_handler.h