[compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp.
authorMax Moroz <mmoroz@chromium.org>
Thu, 6 Feb 2020 16:44:42 +0000 (08:44 -0800)
committerMax Moroz <mmoroz@chromium.org>
Mon, 10 Feb 2020 14:50:59 +0000 (06:50 -0800)
commit5ad62d3b7f7e75df776a4524bda0c9a1a9952a4e
tree19a5fd4ea9476ad60c1cb3077e7a5e3c84ef5c93
parentb1c7bfe6da2b5d171d025bf261f62773470cfc05
[compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp.

Summary:
Nothing critical, just a few potential improvements I've noticed while reading
the code:
- return `false` when symbolizer buffer is too small to read all data
- invert some conditions to reduce indentation
- prefer `nullptr` over `0` for pointers; init some pointers on stack;
- remove minor code duplication

Reviewers: eugenis, vitalybuka

Subscribers: dberris, #sanitizers, llvm-commits, kcc

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D74137
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp