Fix segfault when invoking -var-info-path-expression on a dynamic varobj
authorJan Vrany <jan.vrany@fit.cvut.cz>
Tue, 31 Jul 2018 09:15:44 +0000 (10:15 +0100)
committerSimon Marchi <simon.marchi@ericsson.com>
Tue, 31 Jul 2018 14:13:41 +0000 (10:13 -0400)
commit5abe0f0cc79a753b80bde28d9c0c7fec9bff3c10
treedbcd5afb2099ab8de78e6547553bb2caf634dd0e
parent472fa5eec2cc521ad5ea37091ea2424ea46552ae
Fix segfault when invoking -var-info-path-expression on a dynamic varobj

Invoking -var-info-path-expression on a dynamic varobj lead either in wrong
(nonsense) result or to a segmentation fault in cplus_describe_child().
This was caused by the fact that varobj_get_path_expr() called
cplus_path_expr_of_child() ignoring the fact the parent of the variable
is dynamic. Then, cplus_describe_child() accessed the underlaying C type
members by index, causing (i) either wrong (nonsense) expression being
returned (since dynamic child may be completely arbibtrary value)
or (ii) segmentation fault (in case the index higher than number of
underlaying C type members.

This fixes the problem by checking whether a varobj is a child of a dynamic
varobj and, if so, reporting an error as described in documentation.

gdb/ChangeLog:

* varobj.c (varobj_get_path_expr_parent): Report an error if
parent is a dynamic varobj.

gdb/testsuite/Changelog:

* gdb.python/py-mi-var-info-path-expression.c: New file.
* gdb.python/py-mi-var-info-path-expression.py: New file.
* gdb.python/py-mi-var-info-path-expression.exp: New file.
gdb/ChangeLog
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.python/py-mi-var-info-path-expression.c [new file with mode: 0644]
gdb/testsuite/gdb.python/py-mi-var-info-path-expression.exp [new file with mode: 0644]
gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py [new file with mode: 0644]
gdb/varobj.c