rfkill: fix rfkill_fop_read wait_event usage
authorJohannes Berg <johannes.berg@intel.com>
Tue, 26 Jan 2016 10:29:03 +0000 (11:29 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Feb 2016 20:45:28 +0000 (15:45 -0500)
commit5abd25f01c03b52d8aa39813656782917aa10d9b
tree5216d390ecc2e8b77f3ba83a8fbde202af8ef407
parent8448609ec0b8b36759338905a7a5f620555623d8
rfkill: fix rfkill_fop_read wait_event usage

[ Upstream commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 ]

The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().

Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.

This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.

Cc: stable@vger.kernel.org
Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/rfkill/core.c