MIPS: pic32: treat port as signed integer
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 28 Oct 2022 13:23:44 +0000 (15:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Dec 2022 16:41:02 +0000 (17:41 +0100)
commit5a792c1d4d779cf9d23f188c023fe145656dab28
treebd90456cbc96007a46d034b633a83ef529610cdf
parent144452b42143c380d5b59a694cc66ce91afc84aa
MIPS: pic32: treat port as signed integer

[ Upstream commit 648060902aa302331b5d6e4f26d8ee0761d239ab ]

get_port_from_cmdline() returns an int, yet is assigned to a char, which
is wrong in its own right, but also, with char becoming unsigned, this
poses problems, because -1 is used as an error value. Further
complicating things, fw_init_early_console() is only ever called with a
-1 argument. Fix this up by removing the unused argument from
fw_init_early_console() and treating port as a proper signed integer.

Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/mips/include/asm/fw/fw.h
arch/mips/pic32/pic32mzda/early_console.c
arch/mips/pic32/pic32mzda/init.c