NFC: st21nfca: fix use of uninitialized variables in error path
authorChristophe Ricard <christophe.ricard@gmail.com>
Fri, 14 Aug 2015 20:33:33 +0000 (22:33 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 16 Aug 2015 22:35:07 +0000 (00:35 +0200)
commit5a3570061a131309143a49e4bbdbce7e23f261e7
treee5499982853bc3190364257d51b457d0bc5247bf
parente7723b33077b04648213f043bc22654c54e375e4
NFC: st21nfca: fix use of uninitialized variables in error path

st21nfca_hci_load_session() calls kfree_skb() on unitialized
variables skb_pipe_info and skb_pipe_list if the call to
nfc_hci_connect_gate() failed. Reword the error path to not use
these variables when they are not initialized. While at it, there
seemed to be a memory leak because skb_pipe_info was only freed
once, after the for-loop, even though several ones were created
by nfc_hci_send_cmd.

Fixes: ec03ff1a8f9a
("NFC: st21nfca: Remove skb_pipe_list and skb_pipe_info
useless allocation")

Cc: stable@vger.kernel.org
Acked-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st21nfca/st21nfca.c