Bluetooth: hci_qca: fix potential GPF
authorPavel Skripkin <paskripkin@gmail.com>
Mon, 3 May 2021 10:06:05 +0000 (13:06 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Sat, 26 Jun 2021 05:12:26 +0000 (07:12 +0200)
commit59f90f1351282ea2dbd0c59098fd9bb2634e920e
tree60a694b5235507cb44d5e63c77bc4adeae068040
parent4ef36a52b0e47c80bbfd69c0cce61c7ae9f541ed
Bluetooth: hci_qca: fix potential GPF

In qca_power_shutdown() qcadev local variable is
initialized by hu->serdev.dev private data, but
hu->serdev can be NULL and there is a check for it.

Since, qcadev is not used before

if (!hu->serdev)
return;

we can move its initialization after this "if" to
prevent GPF.

Fixes: 5559904ccc08 ("Bluetooth: hci_qca: Add QCA Rome power off support to the qca_power_shutdown()")
Cc: stable@vger.kernel.org # v5.6+
Cc: Rocky Liao <rjliao@codeaurora.org>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c