bpf: fix ldx in ld_abs rewrite for large offsets
authorDaniel Borkmann <daniel@iogearbox.net>
Mon, 9 Jul 2018 22:43:22 +0000 (00:43 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 10 Jul 2018 15:15:30 +0000 (08:15 -0700)
commit59ee4129a279070d8e2f9dc1660330f6593c7808
treeae2b186ce2f62280bbd74b91a72a9166f8c34d39
parentb9626f45abccd044f8048269c67720f0719f2d4e
bpf: fix ldx in ld_abs rewrite for large offsets

Mark reported that syzkaller triggered a KASAN detected slab-out-of-bounds
bug in ___bpf_prog_run() with a BPF_LD | BPF_ABS word load at offset 0x8001.
After further investigation it became clear that the issue was the
BPF_LDX_MEM() which takes offset as an argument whereas it cannot encode
larger than S16_MAX offsets into it. For this synthetical case we need to
move the full address into tmp register instead and do the LDX without
immediate value.

Fixes: e0cea7ce988c ("bpf: implement ld_abs/ld_ind in native bpf")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/filter.c