usb: max-3421: Fix setting of I/O pins
authorMark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Tue, 7 Feb 2023 03:33:37 +0000 (16:33 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:36 +0000 (09:33 +0100)
commit59b040cf333900c99f5c4bd37272c9fd01ea8aec
treeba5e15ce90b77b4d709d6313c59602eb6c002adc
parent2cfc00e974d75a3aa8155f2660f57d342e1f67ca
usb: max-3421: Fix setting of I/O pins

[ Upstream commit a7efe3fc7cbe27c6eb2c2a3ab612194f8f800f4c ]

To update the I/O pins, the registers are read/modified/written. The
read operation incorrectly always read the first register. Although
wrong, there wasn't any impact as all the output pins are always
written, and the inputs are read only anyway.

Fixes: 2d53139f3162 ("Add support for using a MAX3421E chip as a host driver.")
Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20230207033337.18112-1-mark.tomlinson@alliedtelesis.co.nz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/max3421-hcd.c