HID: input: Fix TransducerSerialNumber implementation
authorJason Gerecke <killertofu@gmail.com>
Tue, 23 Sep 2014 18:09:28 +0000 (11:09 -0700)
committerJiri Kosina <jkosina@suse.cz>
Wed, 29 Oct 2014 09:59:06 +0000 (10:59 +0100)
commit5989a55a4c9aafba8b152c6bf52244510c2b88b9
treefff5a63737ebe850d74b4febb05fc0ae91eb50d5
parentf974008f07a62171a9dede08250c9a35c2b2b986
HID: input: Fix TransducerSerialNumber implementation

The commit which introduced TransducerSerialNumber (368c966) is missing
two crucial implementation details. Firstly, the commit does not set the
type/code/bit/max fields as expected later down the code which can cause
the driver to crash when a tablet with this usage is connected. Secondly,
the call to 'set_bit' causes MSC_PULSELED to be sent instead of the
expected MSC_SERIAL. This commit addreses both issues.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-input.c