broadcom/compiler: always enable per-quad on spill operations
authorIago Toral Quiroga <itoral@igalia.com>
Fri, 1 Apr 2022 06:37:34 +0000 (08:37 +0200)
committerMarge Bot <emma+marge@anholt.net>
Fri, 1 Apr 2022 08:53:50 +0000 (08:53 +0000)
commit597560e27c585d9be17ffdb8731c1c3d88550cf8
tree5785bafdae867e02ab76fd8fc612d790344fde42
parente6d7a6a3b72a95b29bacce4a3a1842144ab9663c
broadcom/compiler: always enable per-quad on spill operations

This ensures that any channels used for helper invocations are
also spilled/filled correctly.

Alternatively, we could recursively track all temps that get
involved in computing values that are then used in explicit
(dfdx,dfdy) or implicit (texture coordinates for mipmap or
anisotropic filtering, etc) derivatives, and only enable
per-quad on these (or disable spilling of any of these
values).

Fixes:
dEQP-VK.graphicsfuzz.cov-dfdx-dfdy-after-nested-loops

Reviewed-by: Alejandro PiƱeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15705>
src/broadcom/ci/broadcom-rpi4-fails.txt
src/broadcom/compiler/vir_register_allocate.c