net: ethernet: ti: davinci_emac: Fix return type of emac_dev_xmit
authorNathan Huckleberry <nhuck@google.com>
Mon, 12 Sep 2022 19:50:19 +0000 (12:50 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Sep 2022 01:23:26 +0000 (18:23 -0700)
commit5972ca946098487c5155fe13654743f9010f5ed5
treea47a811fbc82fb7e7fd9a0926fbf6c55d229d8d0
parent0191580b000d50089a0b351f7cdbec4866e3d0d2
net: ethernet: ti: davinci_emac: Fix return type of emac_dev_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of emac_dev_xmit should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220912195023.810319-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/davinci_emac.c