dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 14 Dec 2020 11:56:52 +0000 (14:56 +0300)
committerVinod Koul <vkoul@kernel.org>
Tue, 29 Dec 2020 04:38:00 +0000 (10:08 +0530)
commit595a334148449bd1d27cf5d6fcb3b0d718cb1b9f
tree71e6559614ae38ef1c52f364152792fb5cb2e37e
parentd645148cc82ca7fbacaa601414a552184e9c6dd3
dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk()

If the dw_edma_alloc_burst() function fails then we free "chunk" but
it's still on the "desc->chunk->list" list so it will lead to a use
after free.  Also the "->chunks_alloc" count is incremented when it
shouldn't be.

In current kernels small allocations are guaranteed to succeed and
dw_edma_alloc_burst() can't fail so this will not actually affect
runtime.

Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/X9dTBFrUPEvvW7qc@mwanda
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dw-edma/dw-edma-core.c