[lld] respect LLVM_EXTERNAL_LIT
authorKonrad Kleine <kkleine@redhat.com>
Thu, 6 Jul 2023 12:05:02 +0000 (14:05 +0200)
committerKonrad Kleine <kkleine@redhat.com>
Thu, 6 Jul 2023 14:35:01 +0000 (16:35 +0200)
commit58fb2c7a6c5edc973ca99eaff6ae73fd032b10b2
tree0047ec9633c3fa5267b6e28ad078ff1fdc32cb0a
parent8af9a373ad95ef49e2f2aa83c021b8043f848ab9
[lld] respect LLVM_EXTERNAL_LIT

Consider a setup without a system-wide installation of lit.
Instead you pass the path to lit like this:

```
cmake ...
-DLLVM_EXTERNAL_LIT=<PATH_TO_LIT_BINARY> ...
```

Then you will run into this error:

```
ninja: error: unknown target 'check-lld'
```

I have a buildbot builder that fails with this message. Here's the
passage that triggers this error:

https://github.com/llvm/llvm-zorg/blob/d3bfd5ccbceb542098c350e4d071ceceac6854cb/zorg/buildbot/builders/annotated/standalone-build.sh#L194-L239

By using `LLVM_EXTERNAL_LIT` instead of `LLVM_LIT` we fix this problem.

See
[here](https://llvm.org/docs/GettingStarted.html#stand-alone-builds) for
a description:

> Both the LLVM_ROOT and LLVM_EXTERNAL_LIT options are required to do stand-alone builds for all sub-projects. Additional required options for each sub-project can be found in the table below.

Differential Revision: https://reviews.llvm.org/D154599
lld/CMakeLists.txt