btrfs: properly report 0 avail for very full file systems
authorJosef Bacik <josef@toxicpanda.com>
Mon, 18 Sep 2023 14:34:51 +0000 (10:34 -0400)
committerDavid Sterba <dsterba@suse.com>
Wed, 20 Sep 2023 18:44:40 +0000 (20:44 +0200)
commit58bfe2ccec5f9f137b41dd38f335290dcc13cd5c
treed210b6d37c439896b2fa682708fdd629544e78c7
parent8ec0a4a5774ab3f91c356c71f24dfba615bee860
btrfs: properly report 0 avail for very full file systems

A user reported some issues with smaller file systems that get very
full.  While investigating this issue I noticed that df wasn't showing
100% full, despite having 0 chunk space and having < 1MiB of available
metadata space.

This turns out to be an overflow issue, we're doing:

  total_available_metadata_space - SZ_4M < global_block_rsv_size

to determine if there's not enough space to make metadata allocations,
which overflows if total_available_metadata_space is < 4M.  Fix this by
checking to see if our available space is greater than the 4M threshold.
This makes df properly report 100% usage on the file system.

CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/super.c