pci: Fix clearing IRQs on reset
authorCole Robinson <crobinso@redhat.com>
Mon, 31 Mar 2014 18:31:44 +0000 (14:31 -0400)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 31 Mar 2014 18:53:34 +0000 (19:53 +0100)
commit58b590148ca1b19f64f533d40e32b5acce5c21e7
tree238f093e6ee30daf378397edd850617f4ad01872
parent7d4d7975e58b66de6a67ecb5aa9656653653a658
pci: Fix clearing IRQs on reset

irq_state is cleared before calling pci_device_deassert_intx, but the
latter misbehaves if the former isn't accurate. In this case, any raised
IRQs are not cleared, which hits an assertion in pcibus_reset:

qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion
`bus->irq_count[i] == 0' failed.

pci_device_deassert_intx should clear irq_state anyways, so add
an assert.

This fixes migration with usb2 + usb-tablet.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
Message-id: 7da1ad94ce027183b4049c2de370cb191b0073c1.1396290569.git.crobinso@redhat.com
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/pci/pci.c