[ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4
authorFangrui Song <i@maskray.me>
Mon, 30 Nov 2020 16:30:19 +0000 (08:30 -0800)
committerFangrui Song <i@maskray.me>
Mon, 30 Nov 2020 16:30:19 +0000 (08:30 -0800)
commit589e10f8586e45ebe9b6409dd29d62f2f40ab52f
treea749e385e834f733809348e0a826fd30ee56310b
parent25c8fbb3d92fd8321af59bb370e901f0e229b1c9
[ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4

clang may produce `movl x@GOTPCREL+4(%rip), %eax` when loading the high 32 bits
of the address of a global variable in -fpic/-fpie mode.

If assembled by GNU as, the fixup emits an R_X86_64_GOTPCRELX with an
addend != -4. The instruction loads from the GOT entry with an offset
and thus it is incorrect to relax the instruction.

If assembled by the integrated assembler, we emit R_X86_64_GOTPCREL for
relocations that definitely cannot be relaxed (D92114), so this patch is not
needed.

This patch disables the relaxation, which is compatible with the implementation in GNU ld
("Add R_X86_64_[REX_]GOTPCRELX support to gas and ld").

Reviewed By: grimar, jhenderson

Differential Revision: https://reviews.llvm.org/D91993
lld/ELF/Arch/X86_64.cpp
lld/test/ELF/x86-64-gotpc-offset.s [new file with mode: 0644]