panfrost: Identify "Base vertex offset" signedness
authorAlyssa Rosenzweig <alyssa@collabora.com>
Tue, 14 Mar 2023 01:22:20 +0000 (21:22 -0400)
committerMarge Bot <emma+marge@anholt.net>
Tue, 14 Mar 2023 23:10:00 +0000 (23:10 +0000)
commit589a0fe865a440d26d4722a5ceeef04055ce5fa5
tree8f6533713860dab10f4d32d0fdc89d2825d4a22c
parent90e78f6008cf5b2cd8a9f11b9a496a80aeee4196
panfrost: Identify "Base vertex offset" signedness

This is signed, not unsigned. We were already passing negatives and silently
relying on 2's complement and C to do the right thing. But that's silly. We
should just, actually do the right thing.

Found while struggling to debug primitive-restart-draw-mode.

v2: Update the other architectures too, including a decode_csf.c change for the
v10 incarnation of this v4-era field.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net> [v1]
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> [v1]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21891>
src/panfrost/lib/genxml/decode_csf.c
src/panfrost/lib/genxml/v10.xml
src/panfrost/lib/genxml/v4.xml
src/panfrost/lib/genxml/v5.xml
src/panfrost/lib/genxml/v6.xml
src/panfrost/lib/genxml/v7.xml
src/panfrost/lib/genxml/v9.xml