tracing: Fix event trigger to accept redundant spaces
authorMasami Hiramatsu <mhiramat@kernel.org>
Sat, 20 Jun 2020 03:46:03 +0000 (12:46 +0900)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:45 +0000 (15:38 -0400)
commit587287ce2af409246f890e102e54eaf0bedff22c
tree176dffc69dd7301789411e342d932e06f2c62933
parent661a55328d45ed53600af2bf37b6893208a9a6ac
tracing: Fix event trigger to accept redundant spaces

commit 6784beada631800f2c5afd567e5628c843362cee upstream.

Fix the event trigger to accept redundant spaces in
the trigger input.

For example, these return -EINVAL

echo " traceon" > events/ftrace/print/trigger
echo "traceon  if common_pid == 0" > events/ftrace/print/trigger
echo "disable_event:kmem:kmalloc " > events/ftrace/print/trigger

But these are hard to find what is wrong.

To fix this issue, use skip_spaces() to remove spaces
in front of actual tokens, and set NULL if there is no
token.

Link: http://lkml.kernel.org/r/159262476352.185015.5261566783045364186.stgit@devnote2
Cc: Tom Zanussi <zanussi@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 85f2b08268c0 ("tracing: Add basic event trigger framework")
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/trace_events_trigger.c