regulator: hi6421v600: Fix setting idle mode
authorAxel Lin <axel.lin@ingics.com>
Sat, 19 Jun 2021 12:34:23 +0000 (20:34 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 21 Jun 2021 12:07:46 +0000 (13:07 +0100)
commit57c045bc727001c43b6a65adb0418aa7b3e6dbd0
treed77c4c8f43a7e630b6310891739f0fa9a47109a8
parent01c5741b82969d096ac0870d997b7d2f5a5fe970
regulator: hi6421v600: Fix setting idle mode

commit db27f8294cd7 changed eco_mode << (ffs(sreg->eco_mode_mask) - 1)
to sreg->eco_mode_mask << (ffs(sreg->eco_mode_mask) - 1) which is wrong.
Fix it by simply set val = sreg->eco_mode_mask.

In additional, sreg->eco_mode_mask can be 0 (LDO3, LDO33, LDO34).
Return -EINVAL if idle mode is not supported when sreg->eco_mode_mask is 0.

While at it, also use unsigned int for reg_val/val which is the expected
type for regmap_read and regmap_update_bits.

Fixes: db27f8294cd7 ("staging: regulator: hi6421v600-regulator: use shorter names for OF properties")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210619123423.4091429-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/hi6421v600-regulator.c