USB: cdc-acm: Fixing crash when ACM probing interfaces with no endpoint descriptors.
authorToby Gray <toby.gray@realvnc.com>
Thu, 2 Sep 2010 09:46:20 +0000 (10:46 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 4 Sep 2010 00:33:41 +0000 (17:33 -0700)
commit577045c0a76e34294f902a7d5d60e90b04d094d0
treed52f624fd527a12b6b7e644b6f0c4fb54e78c67b
parent5b239f0aebd4dd6f85b13decf5e18e86e35d57f0
USB: cdc-acm: Fixing crash when ACM probing interfaces with no endpoint descriptors.

Certain USB devices, such as the Nokia X6 mobile phone, don't expose any
endpoint descriptors on some of their interfaces. If the ACM driver is forced
to probe all interfaces on a device the a NULL pointer dereference will occur
when the ACM driver attempts to use the endpoint of the alternative settings.
One way to get the ACM driver to probe all the interfaces is by using the
/sys/bus/usb/drivers/cdc_acm/new_id interface.

This patch checks that the endpoint pointer for the current alternate settings
is non-NULL before using it.

Signed-off-by: Toby Gray <toby.gray@realvnc.com>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/class/cdc-acm.c